Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure_pull_request_id, github_pull_request_id and gitlab_merge_request_id args to dbt-cloud job run #103

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

Tonayya
Copy link
Contributor

@Tonayya Tonayya commented Sep 1, 2023

Just added these 3 parameters to provide support for triggering CI runs in Github, Gitlab, and AD. As per this PR in dbt-cloud.

Description & motivation

Checklist

  • I have written unit tests for new features (e.g., a new command test case in conftest.py)
  • I have written integration tests for new features (e.g., a new step in the CI workflow)
  • I have added descriptions to new commands and arguments
  • I have updated the README.md (if applicable)

Just added these 3 parameters to provide support for triggering CI runs in Github, Gitlab, and AD. As per [this PR](dbt-labs/dbt-cloud#8303) in dbt-cloud.
@Tonayya
Copy link
Contributor Author

Tonayya commented Sep 3, 2023

@stumelius Hi there, was hoping you could review this PR and let me know if it's possible to add this. Thanks so much! :)

@stumelius
Copy link
Contributor

@Tonayya everything looks good here, good work and thanks for you contribution ❤️ I'll merge this right away

@stumelius stumelius changed the title Update run.py Add azure_pull_request_id, github_pull_request_id and gitlab_merge_request_id args to dbt-cloud job run Sep 7, 2023
@stumelius stumelius merged commit a08cc94 into data-mie:main Sep 7, 2023
@stumelius
Copy link
Contributor

@Tonayya FYI https://github.com/data-mie/dbt-cloud-cli/releases/tag/0.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants